reconcile premature on probes nil -> healthy #317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Maskym Vavilov <[email protected]>
maleck13
approved these changes
Nov 26, 2024
There was a problem hiding this comment.
checked the following
- new gateway no status on healthchecks while dns propigating then becomes healthy (records not published until health passes, dnspolicy shows correct status)
- new gateway no status on healthchecks while dns propigating then stays unhealthy (records not published dnspolicy shows correct status)
- make the health check pass after failing for sometime (records published and dnspolicy shows correct status)
- make healthcheck fail after publish (records remain published dnspolicy shows correct status)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addresses 2 bugs:
Also, integration suite proves to give false positives when it comes to the premature reconciliation logic. We cannot fail those tests confidently so I'm removing them. The premature logic to be tested manually and, probably in the e2e suite #282